518760 - Forum pagination is broken

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

STR:

1. Load http://support-stage.mozilla.org/en-US/forum/1 and click on the pagination numbers / "Next >>" links at the bottom of the page (once past page 1, click "<< Prev" or "1", again)

Expected Results:

Forum pages advance

Actual Results:

You stay at the same forum page

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

FWIW, I wrote https://litmus.mozilla.org/show_test.cgi?id=9530 so we'll not break this again.

Comment 2

[Paul Craciunoiu [:paulc]]

Attachment: SQL patch, v1

This modifies the regexes from bug 416479 attachment 397750 [details] [diff] [review]
Regex 1 was incorrect when other parameters existed, so I added a new one. It may be possible to do this in one regex, but is the safe-and-not-ugly way to do it.

Also, we may want to examine the other regexes for this, but this patch fixes pagination.

Comment 3

[Paul Craciunoiu [:paulc]]

Attachment: SQL patch, v1.1

Oops. Some local leftovers :)

Comment 4

[Shyam Mani [:fox2mike]]

mysql> INSERT INTO tiki_urlt_regex_out (regexid, regex_left, regex_right, regex_flags, continue_flag, comment_text)
    -> VALUES (
    -> '120', '^\\/?tiki-view_forum.php\\?forumId=([0-9]+)(&|&)(.*)$', '/en-US/forum/$1?$3', NULL , NULL , NULL
    -> );
Query OK, 1 row affected (0.00 sec)

mysql> 
mysql> UPDATE tiki_urlt_regex_out SET regex_left = '^\\/?tiki-view_forum.php\\?forumId=([0-9]+)$' WHERE regexid =110 LIMIT 1 ;
Query OK, 1 row affected (0.00 sec)
Rows matched: 1  Changed: 1  Warnings: 0

Ran fine on stage.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

The SQL fix in comment 4 didn't seem to affect (i.e. fix) pagination on staging.

Comment 6

[Paul Craciunoiu [:paulc]]

Attachment: SQL patch for the other tiki-view_forum.php regex

This'll do it for the other regex. I'm not sure if it's necessary, given that we didn't seem to find anything broken. We may alternately just move it to its own bug and mark this fixed.

Comment 7

[Laura Thomson :laura]

If we didn't find anything broken...then let's not fix it.

Comment 8

[Paul Craciunoiu [:paulc]]

Comment on attachment 402773 [details] [diff] [review]
SQL patch for the other tiki-view_forum.php regex

The patch can be left here then and we can decide to use it if problems arise ;)

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #5)
> The SQL fix in comment 4 didn't seem to affect (i.e. fix) pagination on
> staging.

For those playing along at home, the fix was to clear caches (regexp's were cached in the cachelib, or something).

Verified FIXED on production: http://support.mozilla.com/en-US/forum/1.

Comment 10

[David Tenser [:djst]]

So, no code was submitted? Sounds like sumo_only then.