Closed
Bug 518760
Opened 16 years ago
Closed 16 years ago
Forum pagination is broken
Categories
(support.mozilla.org :: Forum, task)
support.mozilla.org
Forum
Tracking
(Not tracked)
VERIFIED
FIXED
1.4
People
(Reporter: stephend, Assigned: paulc)
References
()
Details
(Keywords: regression, Whiteboard: sumo_only)
Attachments
(2 files, 1 obsolete file)
351 bytes,
patch
|
laura
:
review+
|
Details | Diff | Splinter Review |
419 bytes,
patch
|
Details | Diff | Splinter Review |
STR:
1. Load http://support-stage.mozilla.org/en-US/forum/1 and click on the pagination numbers / "Next >>" links at the bottom of the page (once past page 1, click "<< Prev" or "1", again)
Expected Results:
Forum pages advance
Actual Results:
You stay at the same forum page
Reporter | ||
Comment 1•16 years ago
|
||
FWIW, I wrote https://litmus.mozilla.org/show_test.cgi?id=9530 so we'll not break this again.
Assignee | ||
Comment 2•16 years ago
|
||
This modifies the regexes from bug 416479 attachment 397750 [details] [diff] [review]
Regex 1 was incorrect when other parameters existed, so I added a new one. It may be possible to do this in one regex, but is the safe-and-not-ugly way to do it.
Also, we may want to examine the other regexes for this, but this patch fixes pagination.
Assignee: james → paulc
Attachment #402761 -
Flags: review?(laura)
Attachment #402761 -
Flags: review?(james)
Assignee | ||
Comment 3•16 years ago
|
||
Oops. Some local leftovers :)
Attachment #402761 -
Attachment is obsolete: true
Attachment #402762 -
Flags: review?(laura)
Attachment #402762 -
Flags: review?(james)
Attachment #402761 -
Flags: review?(laura)
Attachment #402761 -
Flags: review?(james)
Comment 4•16 years ago
|
||
mysql> INSERT INTO tiki_urlt_regex_out (regexid, regex_left, regex_right, regex_flags, continue_flag, comment_text)
-> VALUES (
-> '120', '^\\/?tiki-view_forum.php\\?forumId=([0-9]+)(&|&)(.*)$', '/en-US/forum/$1?$3', NULL , NULL , NULL
-> );
Query OK, 1 row affected (0.00 sec)
mysql>
mysql> UPDATE tiki_urlt_regex_out SET regex_left = '^\\/?tiki-view_forum.php\\?forumId=([0-9]+)$' WHERE regexid =110 LIMIT 1 ;
Query OK, 1 row affected (0.00 sec)
Rows matched: 1 Changed: 1 Warnings: 0
Ran fine on stage.
Reporter | ||
Updated•16 years ago
|
Reporter | ||
Comment 5•16 years ago
|
||
The SQL fix in comment 4 didn't seem to affect (i.e. fix) pagination on staging.
Updated•16 years ago
|
Attachment #402762 -
Flags: review?(laura) → review+
Assignee | ||
Comment 6•16 years ago
|
||
This'll do it for the other regex. I'm not sure if it's necessary, given that we didn't seem to find anything broken. We may alternately just move it to its own bug and mark this fixed.
Attachment #402773 -
Flags: review?(laura)
Attachment #402773 -
Flags: review?(james)
Assignee | ||
Updated•16 years ago
|
Attachment #402762 -
Flags: review?(james)
Comment 7•16 years ago
|
||
If we didn't find anything broken...then let's not fix it.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•16 years ago
|
||
Comment on attachment 402773 [details] [diff] [review]
SQL patch for the other tiki-view_forum.php regex
The patch can be left here then and we can decide to use it if problems arise ;)
Attachment #402773 -
Flags: review?(laura)
Attachment #402773 -
Flags: review?(james)
Reporter | ||
Comment 9•16 years ago
|
||
(In reply to comment #5)
> The SQL fix in comment 4 didn't seem to affect (i.e. fix) pagination on
> staging.
For those playing along at home, the fix was to clear caches (regexp's were cached in the cachelib, or something).
Verified FIXED on production: http://support.mozilla.com/en-US/forum/1.
Status: RESOLVED → VERIFIED
Comment 10•15 years ago
|
||
So, no code was submitted? Sounds like sumo_only then.
Whiteboard: sumo_only
You need to log in
before you can comment on or make changes to this bug.
Description
•